Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make validatePassword async and pass user to args #1265

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darkbasic
Copy link
Member

@darkbasic darkbasic commented Nov 26, 2023

Tests need to be fixed if we decide to go this route.

See #1242

Copy link

changeset-bot bot commented Nov 26, 2023

🦋 Changeset detected

Latest commit: d6faf8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@accounts/password Major
@accounts/rest-express Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 26, 2023

💻 Website Preview

The latest changes are available as preview in: https://3a0394fe.accounts-js.pages.dev

@darkbasic darkbasic marked this pull request as ready for review November 26, 2023 17:48
@darkbasic darkbasic marked this pull request as draft November 26, 2023 17:51
@darkbasic darkbasic force-pushed the async-password-validation branch from fc90d02 to 88f017d Compare November 26, 2023 17:53
Copy link
Contributor

github-actions bot commented Nov 26, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@accounts/password 1.0.0-alpha-20231126181819-d6faf8d5 npm ↗︎ unpkg ↗︎
@accounts/rest-express 1.0.0-alpha-20231126181819-d6faf8d5 npm ↗︎ unpkg ↗︎

@darkbasic darkbasic force-pushed the async-password-validation branch from 88f017d to d6faf8d Compare November 26, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant